Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4467 closed defect (fixed)

Js Hydra converting some hex strings incorrectly

Reported by: kzar Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords: jshydra
Cc: trev, sebastian Blocked By:
Blocking: #4465, #4468 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29354754/

Description (last modified by trev)

Environment

64 bit Linux, JS Shell 45

How to reproduce

  1. Create a file called jsshell/test.js with the following contents:
    "\x2B\x0E\x03\x02\x1A";
    
  2. Run this command: mozilla-esr45-linux-x86_64/js jshydra.js scripts/abprewrite.js test.js | grep '"' (ensuring the js shell path is correct).

Observed behaviour

Output is: "+\x014\x03\x02\x110";

Expected behaviour

Output should be "+\x0E\x03\x02\x1A";.

Background

Function sanitize() in scripts/astDecompile.js forgets to hex-encode numbers - so instead of A you get 10 in the string literal.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)
  • Owner changed from kzar to trev

comment:2 Changed 3 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by kzar

  • Blocking 4468 added
Note: See TracTickets for help on using tickets.