Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#447 closed defect (fixed)

EHH - TypeError: properties is undefined in composer.js

Reported by: Gingerbread Man Assignee: saroyanm
Priority: P2 Milestone: Element-Hiding-Helper-1.3.1
Module: Extensions-for-Adblock-Plus Keywords:
Cc: smultron45@… Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5728222025089024/

Description (last modified by philll)

Environment

Me: Firefox 31.0a2 (2014-05-07) • Adblock Plus 2.6.0.3807 • EHH 1.3.0.463
Reporter: Presumably Firefox 29.0 • Adblock Plus 2.6 • EHH 1.3
https://adblockplus.org/forum/viewtopic.php?f=11&t=16909

How to reproduce

  1. Press Ctrl+Shift+J (Mac: Command+Shift+J) to bring up the Browser Console.
  2. Click the Adblock Plus icon and choose "Select an element to hide".
  3. Click an element on the web page to bring up the filter composer.
  4. Click the Advanced View button.
  5. Move the mouse cursor up and down over the various items in the Require Attributes box.

Observed behavior

Browser Console gets clogged with entries that read, "TypeError: properties is undefined". File listed is composer.js, lines 119 and 123.

Expected behaviour

There shoudln't be any errors while doing the described actions.

Change History (8)

comment:1 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 6 years ago by philll

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 5 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Platform set to Firefox/Firefox Mobile

comment:8 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.