#4477 closed change (fixed)

Update adblockpluscore dependency and getSelectorsForDomain usage

Reported by: kzar Assignee: kzar
Priority: P4 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian Blocked By: #4167
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29355222/

Description

Background

With issue #4167 we made some changes to how getSelectorsForDomain works, we now need to update the adblockpluscore dependency and modify our usage of it.

What to change

  • Update the adblockpluscore dependency to hg: 7ff7f906eeb9 git:44dafd7. (This won't include any other changes.)
  • Alter the call to getSelectorsForDomainin adblockpluschrome/background.js to pass the criteria parameter instead of specificOnly.

Change History (3)

comment:1 Changed 15 months ago by kzar

  • Priority changed from Unknown to P4
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 4477 - Update adblockpluscore dependency

comment:3 Changed 15 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.