Opened 3 years ago

Closed 3 years ago

#4479 closed defect (fixed)

[codingtools] Default editorconfig settings are not being applied

Reported by: fhd Assignee: fhd
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29355231/

Description

Environment

  • EditorConfig C Core 0.12.1.

How to reproduce

  1. Create a symlink from .editorconfig in the parent directory of the adblockpluschrome repository to codingtools/editorconfig.
  2. In the adblockpluschrome repository, run editorconfig $(pwd)/background.js.

Observed behaviour

editorconfig should print the default properties relevant to background.js (e.g. indend_size).

Expected behaviour

editorconfig prints nothing at all.

Change History (4)

comment:1 Changed 3 years ago by fhd

  • Owner set to fhd
  • Review URL(s) modified (diff)

comment:2 Changed 3 years ago by fhd

  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Fixes 4479 - Default editorconfig settings not being applied

comment:4 Changed 3 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.