Opened 3 years ago

Closed 3 years ago

#4482 closed change (fixed)

Update buildtools reference in abpcrawler to revision hg:46a20922f3db

Reported by: sergz Assignee: sergz
Priority: Unknown Milestone:
Module: Extensions-for-Adblock-Plus Keywords: abpcrawler
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29355252/

Description

Background

It has not been updated for a long time.

The changes imported by this are:

Ticket Summary Component
#4468 Update Js Hydra dependency for hex string fix Automation
#4459 xarfile should not expect Crypto.Signature module to be present Automation
#4382 Use new syntax to catch Python exceptions Sitescripts
#4375 Update dependency from buildtools on jshydra for Python 3 support Automation
#4353 Update Js Shell version, replace non-standard "for each" syntax Automation
#4342 tox fails due to incompatibility of flake8-putty with flake8 3.0 Sitescripts
#4340 Drop dependency on external xar tool Automation
#4339 Replace M2Crypto by PyCrypto Automation
#4336 Drop support for signing Firefox builds Automation
#4192 Build fails when using git repository Automation
#4099 Don't enforce Gecko build IDs to be numerical Automation
#4097 Make JSHydra use SpiderMonkey location from an environment variable if available Automation
#4088 JSHydra-generated module scopes shouldn't be called immediately Automation
#4059 Adapt the manifest for Edge Unknown
#4047 Improve [convert_js] metadata section syntax in adblockpluschrome build scripts Automation
#3952 Fix whitespaces in Python code for compliance with PEP-8 Unknown
#3834 Expose URL constructor to modules Automation
#3822 jsHydra breaks strict-mode Automation
#3760 Remove the "opera" build target Automation
#3704 Consider Edge a seperate platform in the generated "info" module Automation
#3635 ensure_dependencies.py doesn't work when neither a .git nor a .hg directory is present Automation
#3615 Add module prefixes to navigation in generated source code documentation Automation
#3532 Generate notification icon animations on the fly Platform
#3515 Use ES6 promises Platform
#3490 Make multiprocessCompatible the default for our extensions Automation
#3421 Get rid of for each loops in keySelector.js Automation
#3418 Replace expression closures in prefs.js Automation
#3415 Detect application based on UA for Chromium-based browsers Automation
#3404 Add platform directory to devenv path Automation
#3345 Update jshydra dependency to b2cf20ca8547 Automation
#3344 Update jshydra dependency to d6dd3cd33779 Automation
#3260 Remove expression closure from bootstrap.js.tmpl Automation
#3194 Support multiple sources for dependencies using a new syntax Automation
#3039 Generate qunit/index.html using a template and list of scripts in metadata Automation
#3017 Improve file mapping precedence with inherited metadata files Automation
#3002 Write and use getDevEnvPath function for determining the devenv build path Automation
#2972 ensure_dependencies.py doesn't add Git ignore paths relative to the project root Automation
#2968 Implement multi inheritance for metadata files Automation
#2897 Don't add updateURL to Firefox development builds Automation
#2850 Two Firefox windows open when clicking on an external link Automation
#2796 Add DeveloperIdentifier to the generated Safari extension manifest (Info.plist) Automation
#2763 Update jshydra dependency to 95e7329abbf9 Automation
#2711 Allow manipulation of list items in derived metadata files Automation
#2694 Wrong order of parameters `source, target` in logging message Automation
#2665 Spanish translations aren't used in Opera builds Automation
#2109 Generalize translations and allow translating app-independent repositories Automation
#1740 Support "devtools_page" option in Chrome extension manifest Automation
#1434 Remove remaining non-standard JS usage from buildtools Automation
#382 Remove support for "experimental" Chrome builds Automation


changes without issues:

6657d71cdcccBacked out changeset 512717e74592 (not sufficient to support PyCrypto 2.4)Wladimir Palant
e120a0d93303Noissue - Adapt quotes for compliance with our coding style changeset | filesSebastian Noack
0a21b061b2fbNoissue - Got rid of non-defualt script encodings changeset | filesSebastian Noack
cf27cafe5595Noissue - Added flake8/tox configurationSebastian Noack
4ceb86406d75Noissue - Updated jshydra dependency for whitespace changes and minor cleanupSebastian Noack
f4f931d15031Noissue - Updated jshydra dependency to update the copyright year in generated scripts changeset | filesSebastian Noack
c4cf50a4d48cNoissue - Changed license disclaimer in testIndex.html.tmpl to MPL like the rest of buildtoolsSebastian Noack
0af1c5cb6ca5Noissue - Avoid using re module for string splittingDave Barker
c66ddcd03fbcNoissue - Removed unused info.addonID and info.addonRoot for Chrome and SafariSebastian Noack
63bfe89ea328Noissue - Add .gitignore file changeset | filesDave Barker
a61155d8764aNoissue - Avoid "detached head" when using Git branchesDave Barker

Change History (3)

comment:1 Changed 3 years ago by sergz

  • Cc trev added
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.