Changes between Version 3 and Version 6 of Ticket #4486


Ignore:
Timestamp:
10/06/2016 09:24:53 AM (3 years ago)
Author:
sergz
Comment:

The issue is that we check whether the document is whitelisted (as well as element hiding) a wrong way. For example, there is a filter @@||www.google.de^$elemhide,~third-party (on my machine, google redirects to google.de, but it does not matter) and in the engine we call Main.cpp::GetWhitelistingFilter("https://www.google.de/#q=iphone", empty vector, CONTENT_TYPE_ELEMHIDE) which calls GetWhitelistingFilter(urlArg, "", type) and it returns an empty string. However, it should use URL as document URL instead of an empty string, thus call GetWhitelistingFilter(urlArg, urlArg, type).

It has been introduced here.

It does not affect for instance filters like @@||example.org^$elemhide which are created when a web site is manually whitelisted.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4486

    • Property Status changed from reviewing to closed
    • Property Cc philll added
    • Property Summary changed from Acceptable Ads switch is broken on google.com with CSS injection enabled to Broken detection whether a document (root frame) is whitelisted or not
    • Property Resolution changed from to fixed
  • Ticket #4486 – Description

    v3 v6  
    11=== Environment === 
    2 ABP for IE, issue-119-inject-css branch. 
     2ABP for IE, `master` and `issue-119-inject-css` bookmarks. 
    33 
    44=== How to reproduce === 
     
    88 4. Check Acceptable Ads switch in settings to make sure they are enabled 
    99 5. Disable ABP on google.com and refresh the page to make sure the ad is actually served. 
    10 ... 
    1110 
    1211=== Expected behaviour === 
    1312Acceptable Ads should be shown based on a setting on the settings page. 
     13 
     14=== Additional info === 
     15It affects only certain filters, see [https://issues.adblockplus.org/ticket/4486#comment:6  comment #6].