Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#449 closed change (fixed)

Do not override toolbar button's context menu unnecessarily

Reported by: trev Assignee: saroyanm
Priority: P2 Milestone: Adblock-Plus-2.6.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner, saroyanm Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6429432411586560/

Description

Background

By default, we currently show the Adblock Plus menu both on left and right clicks on the toolbar icon (same with status bar icon if it exists). Main reason is that the left click action can be redefined, then you need to right click for the menu. This will be suboptimal as we move to the bubble UI for the menu.

What to change

Only override the default context menu if the left click action has actually been redefined, allow the standard context menu to appear by default.

Change History (8)

comment:1 Changed 6 years ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 6 years ago by saroyanm

This is ,fixed,
but not sure how we should proceed with the issue.
Maybe we can mark the issue as fixed after whole Bubble UI review ?
Anyway if we want to proceed with this issue separately, I can test it with old style overlay.xul.

comment:3 Changed 6 years ago by trev

If this isn't reviewed then it isn't fixed.

comment:4 Changed 6 years ago by saroyanm

Sorry for being not concrete.
So what I wanted to ask is whether this should be reviewed with whole Bubble UI review, or should I create separate review for this issue ?

comment:5 Changed 6 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 6 years ago by saroyanm

I've decided to create it separate while not that much changes.
Please have a look Wladimir when you have time.
Thanks.

comment:7 Changed 6 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
Note: See TracTickets for help on using tickets.