Opened 3 years ago

Closed 2 years ago

#4491 closed change (fixed)

Prevent page front matter from breaking formatting and linting

Reported by: juliandoucette Assignee: jsonesen
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, saroyanm, fhd, trev, sebastian Blocked By:
Blocking: #4488 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29512597/

Description (last modified by juliandoucette)

Background

Our CMS supports page front matter. Although this is effective, it is inconvenient because it messes with formatting, linting, and/or preview in some code and markdown editors.

What to change

Allow page front matter to be surrounded by HTML comments. EG:

<!--
title = Awesome page
description = Awesome description
-->

Change History (11)

comment:1 Changed 3 years ago by juliandoucette

  • Summary changed from Support HTML comments around front matter in CMS to Prevent page front matter from breaking formatting and linting

comment:2 Changed 3 years ago by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 3 years ago by juliandoucette

  • Description modified (diff)

comment:4 Changed 3 years ago by juliandoucette

  • Description modified (diff)

comment:5 Changed 3 years ago by jsonesen

  • Owner set to jsonesen

comment:6 Changed 2 years ago by juliandoucette

Can we bump this to P3 please?

comment:7 Changed 2 years ago by kvas

  • Priority changed from P4 to P3

comment:8 Changed 2 years ago by jsonesen

  • Blocking 4488 added

comment:9 Changed 2 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4491 - Adds handling for block commented page front matter

comment:11 Changed 2 years ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.