Opened 2 years ago

Last modified 10 months ago

#4493 new change

Activate update_as_unapproved flag for translation script (CMS)

Reported by: saroyanm Assignee:
Priority: Unknown Milestone:
Module: Sitescripts Keywords: CMS
Cc: Shikitita, kvas, juliandoucette, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

Currently in the CMS translation script we are not setting update_option flag and because of that we lose translations for some strings when we are doing TYPO change on the English string, or other minor change while, so we would like to add more flexibility to the translation script so the translation will be pushed the way Translation managers expect them.

What to change

Add ability to Set update_option manually before runing translation script, if no flag is set, use default (current) no flag option, otherwise use manually set flag for update_option parameter in translation script when adding or updating the string.

Change History (8)

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:2 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 2 years ago by saroyanm

  • Cc juliandoucette added

comment:4 Changed 2 years ago by jsonesen

  • Cc jsonesen added

comment:5 follow-up: Changed 2 years ago by trev

  • Cc trev added

Set update_as_unapproved value for update_option parameter in translation script when ​adding or updating the string.

That sounds like a huge footgun. This won't merely preserve translations for typos but any changed string. And given that there are almost no approved strings on Crowdin (we simply don't have enough proofreaders for that) nobody will notice when a translation needs updating.

comment:6 in reply to: ↑ 5 Changed 2 years ago by Shikitita

Replying to trev:

Set update_as_unapproved value for update_option parameter in translation script when ​adding or updating the string.

That sounds like a huge footgun. This won't merely preserve translations for typos but any changed string. And given that there are almost no approved strings on Crowdin (we simply don't have enough proofreaders for that) nobody will notice when a translation needs updating.

Regarding "there are almost no approved strings on Crowdin", this is why the communication will change, hopefully, so that whenever the English needs updating, I can approve those translations first so that they'll stay there afterwards (or even having them approved way before those changes are occurring).

Also, we are not talking about translations done by Crowdin users but by the agency. This will help me to keep track of the strings for which the English has changed and the changes themselves. That way I can send the appropriate instructions to them, as it's not the same translating something from scratch than after doing a comparison and realising that only 5 words were updated. This should helps us save time.

comment:7 Changed 21 months ago by saroyanm

  • Description modified (diff)

Sorry for late reply on this issues, the thing is that currently the translation script is being pushed depending on Tamara's decision of the flag, sometimes Tamara requires that the translation are not lost after some text changes which means that if we do so with no flag we will lose all the translation.

So currently the process is so:

  • Tamara tells me the flag she wants to use before the push.
  • After the push she check the changes and manually preserve needed changes in crowdin.
  • I only push the translation that is approved by Tamara.

I've update the ticket so the person who push the change will be able to use the flag required by Translation manager. This will add more flexibility in using translation script and we will be sure that the crowdin is updated the way Translation managers wants to.

Hope current description makes more sense, otherwise we need to reconsider the the way we are managing the translations. Currently we are on the way of defining processes for Website, so this is one crutial part of updating the crowdin the way Translation managers want us to.

comment:8 Changed 10 months ago by fhd

  • Cc trev removed
Note: See TracTickets for help on using tickets.