Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#4495 closed change (fixed)

Remove adblockplustests dependency

Reported by: kzar Assignee: kzar
Priority: P4 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev, rraceanu Blocked By: #4223
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29356068/

Description (last modified by kzar)

Background

For issue #4223 we've been migrating unit tests over from the adblockplustests repository to adblockpluscore. adblockpluschrome makes use of some of those tests and so they should be removed.

What to change

  • Remove the adblockplustests dependency.
  • Update the test runner for adblockpluschrome so the migrated tests are no longer included.
  • Import the preference tests from adblockplustests, removing the branching for Firefox support.

Hints for testers

This is not an issue which you can really test. The developers (are supposed to!) run these unit tests when making changes and should notice if they have broken.

Change History (5)

comment:1 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by kzar

  • Description modified (diff)
  • Summary changed from Update adblockplustests dependency, remove migrated core tests to Remove adblockplustests dependency

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4495 - Remove adblockplustests dependency

comment:4 Changed 2 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by kzar

  • Cc rraceanu added
  • Description modified (diff)

(Added a note about testing Robert.)

Note: See TracTickets for help on using tickets.