Opened 3 years ago

Closed 3 years ago

#4497 closed change (fixed)

Move Utils.getRequestWindow() into child/utils.js

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29356087/

Description

Background

We are currently exposing the functionality to retrieve the DOM window responsible for a request as Utils.getRequestWindow(). This has historical reasons - as we are only dealing with requests and DOM windows in the child process, this functionality is misplaced now.

What to change

Expose getRequestWindow() as an exported function of child/utils.js.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4497 - Move Utils.getRequestWindow() into child/utils.js

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.