Opened on 10/06/2016 at 07:07:14 PM

Closed on 10/07/2016 at 11:00:50 AM

Last modified on 10/20/2016 at 01:25:28 PM

#4499 closed defect (fixed)

$generichide does not work in ABP

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, kzar Blocked By:
Blocking: #524 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mapx)


firefox Version
windows 10

How to reproduce

go to

add @@||^$generichide

In the blockable items list I still can see generic filters

If I add an exception filter[id^="MarketGid"]

I get no hits on such filter in the custom filters list.

Instead, $elemhide is working.

Could be a regression due to #524 ?

In ABP for chrome $generichide is working fine.

Attachments (0)

Change History (6)

comment:1 Changed on 10/06/2016 at 07:10:10 PM by mapx

  • Description modified (diff)

comment:2 Changed on 10/06/2016 at 08:16:48 PM by trev

  • Blocking 524 added
  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set

Yes, definitely a regression from #524. New code is considering the scenario where element hiding is disabled completely but I forgot that on some sites it should be non-generic only.

comment:3 Changed on 10/06/2016 at 08:53:11 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/07/2016 at 11:00:18 AM by abpbot

comment:5 Changed on 10/07/2016 at 11:00:50 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 10/20/2016 at 01:25:28 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set


Firefox 38 / 46 / 49 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.