#4504 closed change (fixed)

Speed up element hiding integration tests

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29356338/

Description

Background

Element hiding integration tests take considerable time right now because of running each check four times: once with no extra filters, once with a document exception rule, once with an invalid document exception rule and once with an element hiding exception rule.

What to change

Have extra tests for the exception rules, like we have them for $generichide already - do not repeat all tests with the exception rules.

Change History (3)

comment:1 Changed 15 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 4504 - Speed up element hiding integration tests

comment:3 Changed 15 months ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.