Opened 9 months ago

Closed 5 months ago

Last modified 6 weeks ago

#4505 closed change (fixed)

Add translations

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu, Shikitita Blocked By: #4602, #4648
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29370727/

Description (last modified by diegocarloslima)

Background

Currently, we only support English.

What to change

Add alternative string resources to provide support to the following languages: Spanish, Polish, Korean, Portuguese, Turkish, German, Greek, Russian, French, Italian and Dutch . The translations should follow the attached translation file.

Attachments (1)

SBrowser_Strings_all translations_Final.xls (64.5 KB) - added by diegocarloslima 6 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 months ago by diegocarloslima

  • Priority changed from Unknown to P2

comment:2 Changed 8 months ago by diegocarloslima

  • Blocked By 4602 added

comment:3 Changed 6 months ago by diegocarloslima

  • Blocked By 4648 added

comment:4 Changed 6 months ago by diegocarloslima

  • Description modified (diff)

Changed 6 months ago by diegocarloslima

comment:5 Changed 6 months ago by diegocarloslima

  • Owner set to diegocarloslima
  • Ready set

comment:6 Changed 6 months ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 4505 - Add translations

comment:8 Changed 5 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 6 weeks ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The following languages properly apply to ABP Samsung Internet when the device language is set to the desired language before app installation (As Designed).

Spanish - ok
Polish - ok
Korean - ok
Portuguese - ok
Turkish - ok
German - ok
Greek - ok
Russian - ok
French - ok
Italian - ok
Dutch - ok

Note: See TracTickets for help on using tickets.