Preferences: Findbar not completely functional in Firefox 52.0a1
|Blocking:||Platform:||Unknown / Cross platform|
Adblock Plus 126.96.36.19907
Firefox 52.0a1 nightly
Mac OS X 10.12
How to reproduce
- Open Filter Preferences.
- Click Find button.
- Type "asdf".
Findbar opens but isn't focused so the text you typed goes nowhere. After clicking the text field you can type in the search text and it appears to work. Error Console shows the following exceptions:
TypeError: this.browser.finder.onFindbarOpen is not a function findbar.xml:738:13
TypeError: this.browser.finder.onFindbarClose is not a function findbar.xml:762:11
TypeError: this.browser.finder.destroy is not a function findbar.xml:427:13
The findbar should be focused when opening and there should be no exceptions.
What to change
The findbar widget once again expects new APIs that we don't provide. We need to stop using it and create a look-alike instead.
Change History (5)
Changed 7 months ago by trev
comment:1 Changed 7 months ago by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed 7 months ago by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed