Opened 21 months ago

Closed 18 months ago

Last modified 14 months ago

#4513 closed change (fixed)

Update app theme

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29356468/

Description

Background

Since our min SDK version is 21 (Lollipop), we should use Material Theming instead of Holo to provide a better user experience.

What to change

Update theme from Holo to Material

Attachments (2)

holo.png (214.2 KB) - added by diegocarloslima 14 months ago.
material.png (146.1 KB) - added by diegocarloslima 14 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 21 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 21 months ago by diegocarloslima

  • Ready set

comment:3 Changed 19 months ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:4 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 4513 - Update app theme

comment:5 Changed 18 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 15 months ago by scheer

@deigocarloslima - is there any way for me to see the difference here, as in, what is the intended look now?

Changed 14 months ago by diegocarloslima

Changed 14 months ago by diegocarloslima

comment:7 Changed 14 months ago by diegocarloslima

@scheer, I've added two screenshots that illustrates the look and feel in the Holo theme and in the Material theme

comment:8 Changed 14 months ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The Material app theme is used correctly across devices.

adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0

adblockplussbrowser-release-signed-1
Galaxy S4
Android 5.0.1

Note: See TracTickets for help on using tickets.