Opened 3 years ago

Closed 3 years ago

#4521 closed change (fixed)

Social Media buttons missing on https://eyeo.com/en/contact

Reported by: rach Assignee: erick
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29367169/

Description (last modified by saroyanm)

Background

Instagram, Facebook and Linkedin Social Media buttons missing and replacement of Twitter Social Media button under https://eyeo.com/en/contact (check "Follow")

What to change

Replace Twitter button with image https://issues.adblockplus.org/attachment/ticket/4521/eyeo-twitter.png linking it to https://twitter.com/eyeo
Add the Facebook button image https://issues.adblockplus.org/attachment/ticket/4521/eyeo-facebook.png linking it to ​https://www.facebook.com/EyeoGmbH
Add the Linkedin button image https://issues.adblockplus.org/attachment/ticket/4521/eyeo-linkedin.png linking it to https://www.linkedin.com/company/eyeo-gmbh
Add the Instagram button image https://issues.adblockplus.org/attachment/ticket/4521/eyeo-instagram.png linking it to https://www.instagram.com/adblockplus/

Attachments (4)

eyeo-facebook.png (406 bytes) - added by rach 3 years ago.
eyeo-twitter.png (758 bytes) - added by rach 3 years ago.
eyeo-linkedin.png (608 bytes) - added by rach 3 years ago.
eyeo-instagram.png (1.1 KB) - added by rach 3 years ago.

Download all attachments as: .zip

Change History (17)

Changed 3 years ago by rach

Changed 3 years ago by rach

comment:1 Changed 3 years ago by rach

  • Description modified (diff)

comment:2 follow-up: Changed 3 years ago by saroyanm

I just wander if it will be more reasonable to move Instagram button here from #4520, because it's more related to the Eyeo than Adblock Plus ?

Changed 3 years ago by rach

comment:3 Changed 3 years ago by rach

  • Description modified (diff)

comment:4 in reply to: ↑ 2 Changed 3 years ago by rach

Replying to saroyanm:

I just wander if it will be more reasonable to move Instagram button here from #4520, because it's more related to the Eyeo than Adblock Plus ?

I think it makes sense to add this here, but I would keep that one under Adblock Plus as well. the image is slightly different though.

Last edited 3 years ago by rach (previous) (diff)

Changed 3 years ago by rach

comment:5 Changed 3 years ago by rach

  • Description modified (diff)

comment:6 Changed 3 years ago by rach

  • Description modified (diff)

comment:7 Changed 3 years ago by saroyanm

  • Component changed from Unknown to Websites
  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Ready set

comment:8 Changed 3 years ago by juliandoucette

  • Keywords goodfirstbug added
  • Priority changed from P4 to P3

comment:9 Changed 3 years ago by erick

  • Owner set to erick

comment:10 Changed 3 years ago by erick

  • Status changed from new to reviewing

comment:11 Changed 3 years ago by saroyanm

  • Review URL(s) modified (diff)

As already was mentioned in #4183: please also add review URL to the ticket after changing the status to the reviewing.

Last edited 3 years ago by saroyanm (previous) (diff)

comment:12 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4521 - Added social media buttons on eyeo contactpage

comment:13 Changed 3 years ago by erick

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.