Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4525 closed change (fixed)

Filter Preferences: Move findbar to the top of the filters list

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29357368/

Description (last modified by trev)

Background

#4510 placed the findbar at the bottom of the filters list. This produces slightly illogical tab order - tabbing away from the findbar brings you to the dialog buttons and the list of subscriptions, not the filters.

What to change

Place the findbar at the top of the filters list. Also make sure to scroll filters in such a way that the search results is displayed at the top of the list - visually close to the findbar.

While at it, it makes sense to put the selected filter to the top of the list as well when coming from blockable items list via "Edit filter in effect."

Change History (7)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Description modified (diff)

comment:4 Changed 3 years ago by abpbot

comment:5 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-2.8-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by Ross

Done. Findbar is now above the list and the tab order feels correct. Results are scrolled to the top of the list as are selections from edit filter in effect.

ABP 2.7.3.4214-beta
Firefox 38 / 46 / 49 / Windows 7
Firefox Nightly 52.0a1 (2016-10-20) / OS X 10.12

comment:7 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set
Note: See TracTickets for help on using tickets.