Opened on 10/13/2016 at 11:52:00 AM

Closed on 10/17/2016 at 03:24:32 PM

Last modified on 10/20/2016 at 01:22:22 PM

#4525 closed change (fixed)

Filter Preferences: Move findbar to the top of the filters list

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)


#4510 placed the findbar at the bottom of the filters list. This produces slightly illogical tab order - tabbing away from the findbar brings you to the dialog buttons and the list of subscriptions, not the filters.

What to change

Place the findbar at the top of the filters list. Also make sure to scroll filters in such a way that the search results is displayed at the top of the list - visually close to the findbar.

While at it, it makes sense to put the selected filter to the top of the list as well when coming from blockable items list via "Edit filter in effect."

Attachments (0)

Change History (7)

comment:1 Changed on 10/14/2016 at 08:06:13 AM by trev

  • Description modified (diff)

comment:2 Changed on 10/14/2016 at 08:12:29 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/14/2016 at 08:23:41 AM by trev

  • Description modified (diff)

comment:4 Changed on 10/17/2016 at 03:23:33 PM by abpbot

comment:5 Changed on 10/17/2016 at 03:24:32 PM by trev

  • Milestone set to Adblock-Plus-2.8-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 10/20/2016 at 01:19:08 PM by Ross

Done. Findbar is now above the list and the tab order feels correct. Results are scrolled to the top of the list as are selections from edit filter in effect.

Firefox 38 / 46 / 49 / Windows 7
Firefox Nightly 52.0a1 (2016-10-20) / OS X 10.12

comment:7 Changed on 10/20/2016 at 01:22:22 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.