Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4527 closed defect (fixed)

TypeError: can't access dead object in child/elemHide.js

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #524 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29357374/

Description (last modified by trev)

Environment

Adblock Plus 2.7.3.4210
Firefox 52.0a1 nightly (2016-10-13)
macOS 10.12

How to reproduce

  1. Press Ctrl/Cmd+Shift+J to open Browser Console.
  2. Go back to the browser window and press Ctrl/Cmd+T to open a new tab.
  3. Type http://cmdrkeene.com/windows-desktop-topology into the location bar and press Enter.
  4. Look at the Browser Console.

Observed behaviour

The following error message shows up:

TypeError: can't access dead object
child/elemHide.js:372

Expected behaviour

No error messages.

Background

This appears to be a regression from #524. In the observer we verify that the window hasn't been garbage collected by means of calling Cu.isDeadWrapper(). However, later we are accessing subject which is the corresponding document - and it appears that it has been garbage collected independently of the window.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

comment:4 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 2.7.3.4214-beta
Firefox Nightly 52.0a1 (2016-10-20) / OS X 10.12

Last edited 3 years ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.