Opened 3 years ago

Closed 3 years ago

#4530 closed change (duplicate)

ABP slows down page load, even if it's disabled for the current domain

Reported by: Alexen Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: kzar, sebastian, mapx Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Windows 10 and Ubuntu 16.04
Chrome 53.0.2785.116 (64-bit)
ABP: 1.12.2

How to reproduce

  1. Disable ABP for a domain.
  2. Open the Timeline in DevTools and refresh page.
  3. Look at the huge amount of time spent on injected javascript(common.js, content.js, include.preload.js + function calls for the extension)

Observed behaviour

On fast pages the load time is increased by so much that it's easy to tell if ABP is installed/in use just by loading a page, and this is on an overclocked i7-6700K and with ABP disabled for the domain.

The time to DOMContentLoaded is usually increased to ~100ms for a page that takes ~38ms if the extension is not installed.

Expected behaviour

When ABP is deactivated for the current domain it should not add any javascript and get out of the way as fast as possible, so it won't waste time parsing and running JS. Basically the first thing it should do on load is: Am I disabled? Ok, I'm out, I won't touch anything!

I actually got a "wow, this is so fast!" experience when I disabled the extension as I was under the impression that deactivated meant that it wouldn't be active other that to check if it is deactivated or not.

I'm sure others also would appreciate a faster experience using ABP on pages where ABP is not needed.

Change History (3)

comment:1 Changed 3 years ago by mapx

  • Cc kzar sebastian mapx added

comment:3 Changed 3 years ago by mapx

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.