Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#4536 closed change (fixed)

Element Hiding Helper should not undo changes to the document

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.10
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29357572/

Description

Background

As of #521, changes to element hiding rules will no longer take effect immediately. So when EHH adds the rule and removes its stylesheet from the document the element in question becomes visible until you reload the page.

What to change

Don't remove the preview stylesheet when a rule is added. In fact, the preview stylesheet should be added in this scenario if the preview wasn't active.

Change History (4)

comment:1 Changed 14 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 14 months ago by abpbot

comment:3 Changed 14 months ago by trev

  • Milestone set to Element-Hiding-Helper-1.3.10
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 14 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

Firefox 38 / 48 / Nightly 52.0a1 (2016-10-23)
Firefox 45 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.