Opened on 10/17/2016 at 09:49:33 AM

Closed on 10/17/2016 at 02:53:52 PM

Last modified on 10/25/2016 at 11:27:54 AM

#4536 closed change (fixed)

Element Hiding Helper should not undo changes to the document

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.10
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



As of #521, changes to element hiding rules will no longer take effect immediately. So when EHH adds the rule and removes its stylesheet from the document the element in question becomes visible until you reload the page.

What to change

Don't remove the preview stylesheet when a rule is added. In fact, the preview stylesheet should be added in this scenario if the preview wasn't active.

Attachments (0)

Change History (4)

comment:1 Changed on 10/17/2016 at 09:59:08 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/17/2016 at 02:52:02 PM by abpbot

comment:3 Changed on 10/17/2016 at 02:53:52 PM by trev

  • Milestone set to Element-Hiding-Helper-1.3.10
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 10/25/2016 at 11:27:54 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set


Firefox 38 / 48 / Nightly 52.0a1 (2016-10-23)
Firefox 45 / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.