Opened 3 years ago

Last modified 2 years ago

#4536 closed change

Element Hiding Helper should not undo changes to the document — at Version 1

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.10
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29357572/

Description

Background

As of #521, changes to element hiding rules will no longer take effect immediately. So when EHH adds the rule and removes its stylesheet from the document the element in question becomes visible until you reload the page.

What to change

Don't remove the preview stylesheet when a rule is added. In fact, the preview stylesheet should be added in this scenario if the preview wasn't active.

Change History (1)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.