Opened 6 months ago

Closed 6 months ago

#4544 closed change (fixed)

Consider platformHTMLBindings.xml when detecting available keyboard shortcuts

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Build-and-Release-Tools Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361133/

Description

Background

keySelector.js currently looks for <xul:key> elements in the browser window when determining which shortcuts are already taken. This check misses Accel-Shift-V key however ("paste as plain text").

What to change

Take <xbl:handler> elements from chrome://global/content/platformHTMLBindings.xml into consideration as well, this is where Accel-Shift-V key is defined.

Change History (5)

comment:1 Changed 6 months ago by trev

  • Summary changed from Consider platformHTMLBindings.xml when detecting available keyboard shortcust to Consider platformHTMLBindings.xml when detecting available keyboard shortcuts

comment:2 Changed 6 months ago by trev

  • Owner set to trev

comment:3 Changed 6 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 6 months ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.