Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4548 closed change (fixed)

Adapt release automation for Safari and Edge

Reported by: sebastian Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, kvas, jsonesen, trev Blocked By:
Blocking: #4551, #4581 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29357701/

Description (last modified by trev)

Background

Currently, build.py release -t chrome will generate release builds for Chrome and Safari. However, we want to release for Chrome and Safari separately from now on, with Adblock Plus for Safari being released out of a bookmark.

Release builds for Microsoft Edge are currently manually created, out of a separate repository. In the next step, we want to move Edge support into a bookmark in adblockpluschrome and use the release automation (see #4028).

(For the related sitescripts changes, for the development builds, see #4540.)

What to change

  • Implement build.py release -t safari|edge, generating release builds for Safari and Microsoft Edge respectively.
  • Change build.py release -t chrome, so that it doesn't create a Safari build anymore.

Change History (8)

comment:1 Changed 3 years ago by kzar

  • Cc trev added
  • Description modified (diff)
  • Owner set to kzar

comment:2 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 3 years ago by trev

  • Description modified (diff)

Release automation doesn't care about revisions, it always uses the current repository state. So bookmarks are irrelevant here, I removed this requirement from "what to change."

comment:4 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by kzar

  • Blocking 4551 added

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4548 - Split out Safari and add Edge release automation

comment:7 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by kzar

  • Blocking 4581 added
Note: See TracTickets for help on using tickets.