Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4555 closed change (rejected)

Use imports instead of fully qualified name in BrowserApp

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29358377/

Description

Background

In order to provide better code readability, change fully qualified name usage to simple name + imports in BrowserApp.java

What to change

Replace instances that contains fully qualified name by its simple name and add an import statement

Change History (5)

comment:1 Changed 3 years ago by diegocarloslima

  • Blocking 3135 added

comment:2 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by fhd

  • Ready unset

Please note that we avoided the imports deliberately to avoid conflicts with upstream merges - BrowserApp.java gets changed a lot by Mozilla. In general we're trying to modify as few lines as possible when we touch upstream code.

If you still think it'd be better to use imports, let's get a third opinion.

comment:4 Changed 3 years ago by diegocarloslima

  • Resolution set to rejected
  • Status changed from reviewing to closed

As we discussed on IRC, we'll keep the changes on upstream code minimal, meaning that we keep fully qualified names

comment:5 Changed 3 years ago by diegocarloslima

  • Blocking 3135 removed
Note: See TracTickets for help on using tickets.