Opened 6 years ago

Last modified 5 years ago

#455 closed defect

Find function in Filter Preferences - No indication when keyword is not found — at Version 9

Reported by: Crits Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: smultron45@…, fhd, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5754941108912128

Description

Environment

Windows 7 x64 SP1
Firefox 19.0
ABP 2.6.0.3810

How to reproduce

  1. Open filter preferences
  2. Click the Search button
  3. Start typing a keyword that does not exist in your filter lists

Observed behaviour

No indication (color change or sound) is given when the searched keyword is not found.

Expected behaviour

The search function should mimic the one of Firefox, i.e. at least color the search box background in red, and possibly make a sound, when the keyword is not found.

Change History (9)

comment:1 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 6 years ago by philll

  • Type changed from defect to change

That's a not-existing feature and thereby a change request rather than a bug.

comment:3 Changed 6 years ago by Crits

Note that I made a mistake in the "component" field, it should be Adblock Plus for Firefox and not for Android.

comment:4 Changed 6 years ago by mapx

  • Component changed from Adblock-Plus-for-Android to Adblock-Plus-for-Firefox

comment:5 Changed 5 years ago by philll

  • Platform set to Firefox

comment:6 Changed 5 years ago by trev

  • Cc fhd added
  • Priority changed from Unknown to P3
  • Ready set
  • Type changed from change to defect

Actually, it is a bug - the find bar can indicate failed searches and our code is supposed to tell the find bar to do it. Not sure why it doesn't happen.

comment:7 Changed 5 years ago by trev

  • Cc trev added

Actually, our implementation is correct. It's simply that https://bugzilla.mozilla.org/show_bug.cgi?id=958101 changed the API once again, onFindResult now expects an object with various properties instead of multiple parameters. At least that's what we have in Firefox 29 and above - @Crits, I guess you meant Firefox 29 rather than Firefox 19?

comment:8 Changed 5 years ago by trev

  • Owner set to trev

comment:9 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.