Opened 3 years ago

Closed 2 years ago

#4566 closed change (fixed)

Remove crashreporter check from adblockbrowser-build/build.py

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: Unknown Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #2490
Blocking: #3768, #4677 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29359878/

Description (last modified by diegocarloslima)

Background

Since crashreporter will be disabled without the need of adding --disable-crashreporter to mozconfig, we don't need to check for it on build.py anymore

What to change

Remove --disable-crashreporter check from build.py

Hints for Testers

Similarly to #2490 , this can be verified as disabled by checking if MOZ_CRASHREPORTER = false in AppConstants.java after building the project. It should always be false, no matter the mozconfig configuration

Change History (8)

comment:1 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by diegocarloslima

  • Blocking 4677 added

comment:3 Changed 3 years ago by abpbot

comment:4 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by diegocarloslima

  • Blocking 3768 added

comment:6 Changed 2 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Is there any hints for testers or way for me to check such a change?

comment:7 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:8 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
  • MOZ_CRASHREPORTER = false in AppConstants.java.

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.