Opened on 10/25/2016 at 01:06:50 PM

Closed on 07/05/2017 at 08:46:30 AM

#4567 closed change (fixed)

Remove disable-crashreporter option from adblockbrowser-build mozconfig files

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: Unknown Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #2490
Blocking: #3768, #4677 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by diegocarloslima)


Since crashreporter will be disabled without the need of adding --disable-crashreporter option, we don't need to have them in mozconfig files anymore

What to change

Remove ac_add_options --disable-crashreporter from all mozconfig files

Hints for Testers

Similarly to #2490 , this can be verified as disabled by checking if MOZ_CRASHREPORTER = false in after building the project. It should always be false, no matter the mozconfig configuration

Attachments (0)

Change History (8)

comment:1 Changed on 10/25/2016 at 03:11:18 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/30/2016 at 01:54:52 PM by diegocarloslima

  • Blocking 4677 added

comment:3 Changed on 12/12/2016 at 11:32:21 AM by abpbot

comment:4 Changed on 12/12/2016 at 11:39:09 AM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 12/28/2016 at 06:24:19 PM by diegocarloslima

  • Blocking 3768 added

comment:6 Changed on 06/21/2017 at 08:31:25 AM by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

Would there be any effective way to test this change? Could we have some hints for testers?

comment:7 Changed on 06/30/2017 at 08:43:45 PM by diegocarloslima

  • Description modified (diff)

comment:8 Changed on 07/05/2017 at 08:46:30 AM by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set
  • MOZ_CRASHREPORTER = false in

Galaxy S7
Android 7.0

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.