Changes between Initial Version and Version 4 of Ticket #4569


Ignore:
Timestamp:
10/26/2016 06:17:03 PM (4 years ago)
Author:
trev
Comment:

I identified the bug in _ensure_line_exists() function, added the analysis to the description.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4569

    • Property Cc trev kzar added
    • Property Owner set to trev
  • Ticket #4569 – Description

    initial v4  
    1818 
    1919I wonder if we really need this code though, I think we will constantly run into bugs or git/hg updates that need addressing which will cause this code to break.  Would it not just be easier to explicitly list the dependences as folders to ignore in ignore files? and remove this code. 
     20 
     21=== Background === 
     22 
     23Function `_ensure_line_exists()` always removes all previous content from the file instead of merely adding a line. It doesn't seek before reading file's contents, so it attempts reading from the end of the file. As a result, it doesn't read anything.