Opened 3 years ago

Closed 3 years ago

#4578 closed change (fixed)

Make uap3:AppExtension.Id configurable for Microsoft Edge builds

Reported by: sebastian Assignee: wspee
Priority: P2 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: kvas, oleksandr Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29368690

Description (last modified by wspee)

Background

During the review of the packager (#4028), I claimed that the Id attribute of the uap3:AppExtension node in AppxManifest.xml always needs to be set to EdgeExtension. Hence it got hard-coded, but apparently this was a misconception.

Initially, that value could be set to any floating point number. However, changing this field caused Microsoft Edge to recognize the extension as a completely different extension. So they changed the validation in the Windows Store to force this field to be set to EdgeExtension (string) for all new extensions (like our development build), while forcing the value not to change for existing extensions (like our release version).

So now we are in a situation where the Adblock Plus development builds must use the value EdgeExtension, while the release builds need to keep the value 1.0.

What to change

Add a metadata option to make the Id attribute of the uap3:AppExtension node in AppxManifest.xml configure. Fall back to EdgeExtension if the option is missing.

Change History (5)

comment:1 Changed 3 years ago by sebastian

  • Keywords goodfirstbug added

comment:2 Changed 3 years ago by wspee

  • Owner set to wspee

comment:3 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by wspee

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Summary changed from uap3:AppExtension.Id depends on the Microsoft Edge extension to Make uap3:AppExtension.Id configurable for Microsoft Edge builds
Note: See TracTickets for help on using tickets.