Opened 3 years ago

Last modified 3 weeks ago

#4580 new change

Remove the remaining ext code

Reported by: kzar Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, mjethani, greiner Blocked By: #4551, #4579
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29569649
https://codereview.adblockplus.org/29573795
https://codereview.adblockplus.org/29573801
https://codereview.adblockplus.org/29573726
https://codereview.adblockplus.org/29730652
https://codereview.adblockplus.org/29737568
https://codereview.adblockplus.org/29737602
https://codereview.adblockplus.org/29752564
https://codereview.adblockplus.org/29760680

Description

Background

For issue 4551 we are looking to remove the Safari code. Then in issue 4579 we are targeting the browserext API consistently, with only a small pollyfill for Chrome.

The next thing we want to do is to remove or migrate any remaining ext platform code that hasn't already been removed.

What to change

  • Replace the PageMap class and all instances with a single Map.
  • Move any ext code that is still required (apart from the Chrome browserext pollyfill) out of ext.

Change History (20)

comment:1 Changed 3 years ago by kzar

  • Blocked By 4551 added

comment:2 Changed 2 years ago by kzar

  • Cc mjethani added

FYI I think this is the issue that Sebastian was referring to recently Manish. I guess we should tweak it though, since we're no longer planning to do the changes in #4579 in the immediate future.

comment:3 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Replace ext.i18n.getMessage with i18n.getMessage

comment:4 Changed 20 months ago by greiner

  • Cc greiner added

comment:5 Changed 20 months ago by mjethani

  • Owner set to mjethani

comment:6 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Replace ext.i18n with i18n

comment:8 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Remove ext.backgroundPage.getWindow

comment:9 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Replace ext.getURL with extension.getURL

comment:11 Changed 18 months ago by tschuster

I am going to work on remove at least ext.webRequest, but I will try to get more done.

comment:12 Changed 15 months ago by sebastian

  • Review URL(s) modified (diff)

comment:13 Changed 15 months ago by sebastian

  • Review URL(s) modified (diff)

comment:14 Changed 15 months ago by mjethani

  • Review URL(s) modified (diff)

comment:16 Changed 14 months ago by sebastian

  • Review URL(s) modified (diff)

comment:17 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Removed ext.webRequest.handlerBehaviorChanged()

comment:18 Changed 14 months ago by sebastian

  • Review URL(s) modified (diff)

comment:19 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 4580 - Removed ext.storage

comment:20 Changed 3 weeks ago by sebastian

  • Owner mjethani deleted
Note: See TracTickets for help on using tickets.