Blockable items list calls reloadDisabledFilters() unnecessarily often
|Blocking:||Platform:||Unknown / Cross platform|
Description (last modified by trev)
Firefox 52.0a1 (2016-10-28 nightly) - multiprocess enabled
Adblock Plus 184.108.40.20622-beta
How to reproduce
- Press Ctrl/Cmd-Shift-V to open Blockable items list.
- Load http://heise.de/
The page loads considerably slower than with Blockable items list closed.
There shouldn't be a significant slowdown.
Profiling shows that the blockable items list keeps calling reloadDisabledFilters() function. This is supposed to happen when filters change, it is currently being triggered by filter hits as well however.
Hints for testers
This change affects Blockable items list displaying disabled filters, the functionality should stay unchanged. If a disabled filter would normally match an allowed request, the Blockable items list should indicate that - and it should consider filters that were disabled while the list is already open. This functionality ignores subscriptions and filter groups that are completely disabled, so changes here should be reflected properly as well.
Change History (6)
comment:1 Changed 5 months ago by trev
comment:3 Changed 5 months ago by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed