Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4589 closed change (fixed)

Update buildtools dependency to revision dadad687f607

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description

Background

We need to get #4544 into Adblock Plus for Firefox. The dependency update will also import #4584 which is purely a tooling change.

What to change

Update dependency and run ensure_dependencies.py before committing.

Change History (6)

comment:1 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4589 - Update buildtools dependency to revision dadad687f607

comment:2 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 3 years ago by Ross

After reading the referenced tickets and their patches I'm not sure how to test this?

comment:4 Changed 3 years ago by trev

You can only test #4544 - you should be able to paste as text in Google Docs using Ctrl/Cmd-Shift-V keyboard shortcut, and the Adblock Plus keyboard shortcut to open blockable items should change into Ctrl/Cmd-Shift-U. However, there appear to be timing issues so occasionally we'll still get the old keyboard shortcut for blockable items.

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working as described in #4544. Should I open another ticket for the timing issue (saw it too)?

ABP 2.8.1.4231-beta
Firefox 38 / 49 / Windows 7
Firefox Nightly 53.0a1 / OS X 10.10

comment:6 Changed 3 years ago by trev

Yes, please open a new ticket, it's not going to block the release.

Note: See TracTickets for help on using tickets.