Opened 5 years ago

Closed 19 months ago

#459 closed defect (incomplete)

Writing Adblock Plus filters page

Reported by: Gingerbread Man Assignee:
Priority: P5 Milestone:
Module: Websites Keywords:
Cc: philll, saroyanm, lisabielik, arthur, wspee, ire Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by Gingerbread Man)

  1. https://adblockplus.org/en/filters#whitelist

Sometimes you will notice that one of your filters that is usually working quite well blocks in some case blocks something that it shouldn't be blocking.
There's a second, redundant "blocks" in there. You could change the above to
Sometimes you will notice that one of your filters that is usually working quite well, in some case blocks something that it shouldn't be blocking.

All mentions of version requirements need to go away, for two reasons. First of all, the versions listed as required are ancient at this point. The highest listed is 1.3.5, which was released on March 25th, 2011. No excuse not to have at least a version that old, so that's just useless information in a document that's already very lengthy and somewhat difficult to understand.
Secondly, the page was originally written back when Adblock Plus was Firefox-specific. The version numbers listed are meaningless for people using other browsers.

  1. https://adblockplus.org/en/filters#anchors

Remove (requires Adblock Plus 1.1 or higher) from the bottom of this section.

  1. https://adblockplus.org/en/filters#separators

Remove (requires Adblock Plus 1.1 or higher) from the end of the second paragraph.

  1. https://adblockplus.org/en/filters#options

Remove (Adblock Plus 1.2 and higher required) from the elemhide example.

Remove the donottrack example. Do-Not-Track support was removed back in 2012.

  1. https://adblockplus.org/en/filters#elemhide_domains

Note: Due to the way how element hiding is implemented, you really can only limit it to full domain names. You cannot use any other part of the address and you cannot use domain as a replacement for domain.example,domain.test.

That's not true. You can limit filters to TLDs, like so:
org##div

Remove (requires Adblock Plus 1.1 or higher) from the beginning of the second paragraph.

Element hiding rules with domain limitation can be used to hide browser's user interface elements as well. This only applies to Firefox, Seamonkey and related browsers. This should be made clear.

  1. https://adblockplus.org/en/filters#elemhide_css

In general, any CSS selector supported by Firefox can be used for element hiding.
(note that not all selectors are supported by Firefox yet).
Turn these into general statements, rather than Firefox-specific.

  1. https://adblockplus.org/en/filters#elemhide_simplified

I can't get this to work. If support has been removed, this section should be deleted as well.

Change History (22)

comment:1 Changed 5 years ago by philll

  • Keywords adblockplus.org update added

Thanks for the hint! We are starting to scan/update the whole website contents of adblockplus.org by this/next week step by step. I will definitely let the whole filter page check by a developer.

comment:2 Changed 5 years ago by philll

  • Keywords update removed

comment:3 Changed 5 years ago by Gingerbread Man

  • Keywords content added
  • Platform set to Unknown

comment:4 Changed 5 years ago by Gingerbread Man

  • Description modified (diff)
  • Summary changed from Writing Adblock Plus filters page - update limiting rules to certain domains to Writing Adblock Plus filters page

comment:5 Changed 5 years ago by trev

  • Component changed from Infrastructure to Websites

comment:6 Changed 5 years ago by saroyanm

  • Priority changed from Unknown to P3

comment:7 Changed 3 years ago by juliandoucette

  • Cc philll saroyanm added
  • Tester set to Unknown

Thanks for the hint! We are starting to scan/update the whole website contents of adblockplus.org by this/next week step by step. I will definitely let the whole filter page check by a developer.

@philll, @saroyanm, what were the results of this?

comment:8 Changed 3 years ago by philll

The page should be rewritten when updating the leftovers that did not move to the help center. Nothing happened here.

comment:9 Changed 3 years ago by juliandoucette

  • Priority changed from P3 to Unknown

comment:10 Changed 3 years ago by juliandoucette

  • Blocked By 4695 added
  • Priority changed from Unknown to P5

comment:11 Changed 3 years ago by juliandoucette

  • Blocked By 4695 removed

comment:12 Changed 3 years ago by juliandoucette

  • Blocked By 4695 added

comment:13 Changed 3 years ago by juliandoucette

  • Priority changed from P5 to Unknown

comment:14 Changed 3 years ago by juliandoucette

  • Cc lisabielik authur added
  • Keywords adblockplus.org content removed
  • Priority changed from Unknown to P5

@lisa & @arthur can you take a look at this? Does it make sense to at least remove invalid content before we launch the help center?

comment:15 Changed 3 years ago by lisabielik

@juliandoucette

I agree with @philll - the page should be rewritten. For now, we aren't adding this document to the help center (the goal is to add it down the road, after ABP and ABB topics are all added).

@arthur, is this document accurate? I think we should update or remove anything that's no longer accurate/relevant.

comment:16 Changed 2 years ago by arthur

  • Cc arthur added; authur removed

@juliandoucette @lisabielik
Unfortuntely, my name was mispelled when so I learned about this issue just yesterday.

Agreeing on the suggestion in 1.

I agree on removing the old version requirements but what about newer ones like for $websocket (2.8 in ABP for FF)? If we want to keep it, we probably should also mention Chrome's version requirements.

Agreeing on removing the donottrack paragraph.

Regarding TLDs in element hiding filters: true. What wbout changing

Note: Due to the way how element hiding is implemented, you really can only limit it to full domain names. You cannot use any other part of the address and you cannot use domain as a replacement for domain.example,domain.test. to

Note: You cannot use domain as a replacement for domain.example,domain.test.

And add something like this before it: You can limit element hiding filters to top-level domains as well. Example: com##.sponsor would be applied on any domain ending with .com.

Element hiding rules with domain limitation can be used to hide browser's user interface elements as well. This only applies to Firefox, Seamonkey and related browsers. This should be made clear.

Agree. I assume it applies to all Gecko-based browsers but I'm not entirely sure.

  1. https://adblockplus.org/en/filters#elemhide_css

In general, any CSS selector supported by Firefox can be used for element hiding. (note that not all selectors are supported by Firefox yet). Turn these into general statements, rather than Firefox-specific.

Not sure how it looks like today. Are there any selectors that aren't supported by current browsers?

  1. https://adblockplus.org/en/filters#elemhide_simplified

I can't get this to work. If support has been removed, this section should be deleted as well.

I cannot confirm this. #div(id=content) does hide the content for me on eyeo.com. So I think this section should stay for now.

comment:17 Changed 2 years ago by juliandoucette

  • Blocked By 4695 removed
  • Cc wspee iaderinokun added
  • Priority changed from P5 to P3

@wspee can you please get to the bottom of this and update the ticket description.

comment:18 Changed 2 years ago by ire

  • Cc ire added; iaderinokun removed

comment:19 Changed 2 years ago by juliandoucette

  • Priority changed from P3 to P5

comment:20 Changed 21 months ago by jeen

  • Milestone set to help.eyeo.com 1.0.0

comment:21 Changed 21 months ago by philll

  • Milestone help.eyeo.com 1.0.0 deleted

I still think that the official filter documentation is not something that will live in the help center.

comment:22 Changed 19 months ago by juliandoucette

  • Resolution set to incomplete
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.