Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4592 closed change (fixed)

Adapt messaging code for the new element hiding emulation filters

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By: #4394
Blocking: #4658, #4659, #4659 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361722/

Description

Background

#4394 replaces CSS property filters with the more generic element hiding emulation filters.

What to change

The messaging code in the UI repository needs to be adapted to work with the new element hiding emulation filters.

Change History (8)

comment:1 Changed 3 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by fhd

  • Blocking 4658 added

comment:3 Changed 3 years ago by fhd

  • Blocked By 4394 added
  • Blocking 4659 added; 4394 removed

comment:4 Changed 3 years ago by fhd

  • Summary changed from Adapt for element hiding emulation filters to Adapt messaging code for the new element hiding emulation filters

comment:5 Changed 3 years ago by fhd

  • Blocking

comment:7 Changed 3 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by Ross

Tested this change as part of #4658 and it appears to be working okay.

(Leaving ticket open until Chrome changes).

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Beta (54.0b2)
Windows 7

Note: See TracTickets for help on using tickets.