Opened 2 years ago

Closed 20 months ago

#4598 closed defect (fixed)

Scripts that supposed to be blocked aren't

Reported by: arthur Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, kzar, innerself, mapx, rhana@… Blocked By: #4647
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


Win 10 Pro
Chrome 54.0.2840.87 m (64-bit)
ABP 1.12.4 and
Custom filter: @@||$domain=allestö

How to reproduce

  1. Create a new tab and open the developer tools for it. Switch to the Network tab.
  2. Browse to http://allestö in the new tab.
  3. Type into the Filter box at the top left of the developer tools Network tab.

Observed behaviour

The ads?gdfrp_req=1&correlator=... requests aren't blocked. They also aren't visible in the Adblock Plus developer tools tab.

Expected behaviour

Those requests should be blocked and listed as such in the Adblock Plus tab.

Change History (25)

comment:1 Changed 2 years ago by mapx

  • Cc mapx added

comment:2 Changed 2 years ago by mapx

reproducible also:

  • use only easylist
  • add this filter

@@||$ wont be blocked

comment:3 Changed 2 years ago by mapx

same behaviour here:


securepubads is not blocked

comment:4 Changed 2 years ago by kzar

  • Owner set to kzar

Have you guys tried reproducing this on Firefox or Safari?

comment:5 Changed 2 years ago by mapx

securepubads correctly blocked in abp for firefox

comment:6 Changed 2 years ago by arthur

They seem to be blocked in Safari 10.0 with ABP

Last edited 2 years ago by arthur (previous) (diff)

comment:7 Changed 2 years ago by kzar

I'm having difficulty reproducing this. I don't see any requests to being made, allowed or blocked by either site. (I also tried changing the filter since I noticed the script is now pubads_impl_105.js.)

What did you mean by "the search field" in the steps to reproduce, the URL bar, search field in the Adblock Plus devtools pane or something else?

comment:8 Changed 2 years ago by mapx

  • search field in the network tab
  • however, I tested again both sites, now the securepubads are blocked (chrome Version 55.0.2883.44 beta (64-bit), ABP and visible also in dev ABP panel. Weird ..
Last edited 2 years ago by mapx (previous) (diff)

comment:9 Changed 2 years ago by arthur

  • Description modified (diff)

Sorry for not being very clear, udpated the steps to reproduce.

Still happening for me with Chrome Beta 55.0.2883.44 and ABP

comment:10 Changed 2 years ago by kzar

Thanks for clarifying but still struggling to reproduce this. When I type "" into the search field for the Network request tab I don't get any matches for either website. Even when I disable all Adblock Plus filters.

comment:12 Changed 2 years ago by kzar

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

Aha finally got it, I was using the search feature (C-f) instead of the filter box at the top left. (Kind of confusing UI since for the profiler you hit C-f to do the same thing.)

comment:13 Changed 2 years ago by kzar

  • Blocked By 4647 added

The request is being made inside an iframe which looks something like this:

<iframe id="google_ads_iframe_/11637228/"
        title="" name="google_ads_iframe_/11637228/"
        width="0" height="0" scrolling="no" marginwidth="0" marginheight="0"
        frameborder="0" srcdoc=""
        style="border: 0px; vertical-align: bottom; visibility: hidden; display: none;">
      <script type="text/javascript">
        function callbackProxy(adContents) {
          window.parent.googletag.impl.pubads.setAdContentsBySlotForAsync(adContents, 1);
      <script src=";correlator=..."></script>
    <body marginwidth="0" marginheight="0">
  1. Firstly the iframe often performs the request before its onCommitted event was fired which triggers an exception (see #4647).

2. Secondly the frame URL of about:srcdoc seems to be confusing our logic somehow in a way that I don't yet understand.

Continuing to investigate...

Last edited 2 years ago by kzar (previous) (diff)

comment:14 Changed 2 years ago by kzar

Nope, looks like this has the same cause as #4647. I was just mistaken since my fix had a typo...

comment:15 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:16 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)

comment:17 Changed 2 years ago by kzar

  • Cc rhana@… added

comment:18 Changed 22 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:19 Changed 21 months ago by kzar

  • Description modified (diff)

(Still waiting for codereview, but just updated the test filter since the page has changed a little since the issue was last updated.)

comment:20 Changed 20 months ago by kzar

  • Description modified (diff)

comment:21 Changed 20 months ago by kzar

I wanted to check my modified fix still works but I'm having trouble reproducing the problem at all now. Can anyone else still reproduce this / know another site where this still happens?

comment:22 Changed 20 months ago by arthur

I also couldn't reproduce this anymore.

comment:23 Changed 20 months ago by kzar

Yea, I guess they updated their website. If anyone does find a new site that breaks in a similar way post a link here, it would be useful for testing.

comment:24 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 4598,4599,4647,4804 - Work around onCommitted flaw

comment:25 Changed 20 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.