Changes between Version 7 and Version 9 of Ticket #4603


Ignore:
Timestamp:
11/28/2016 01:47:12 PM (3 years ago)
Author:
kzar
Comment:

The filter composer highlights elements by creating an overlay on top of them which is translucent yellow / red. The troublesome filter was simply hiding those elements!

Turns out our code had a typo, it was giving the overlay elements the style of display: inline-box instead of display: inline-block, but I also needed to add !important in order to fix this problem.

(What made this a little trickier to debug was that a code comment was out of date and the code was a little confusing. (We used to sometimes highlight elements by adding styles to them, instead of always using overlays. But that is no longer the case.) I added another review to at least improve the comments.)

Legend:

Unmodified
Added
Removed
Modified