Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4607 closed change (fixed)

Default content styles

Reported by: saroyanm Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: juliandoucette, jeen, p.pastourmatzis, mvelchevski, greiner Blocked By:
Blocking: #4606, #4629 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361647/

Description (last modified by juliandoucette)

Background

We would like to define a subset of HTML5 that is also supported by markdown that we recommend using in websites content and covering in website styleguides. We will provide sensible default styles for these elements in the form of a component.

HTML5 Subset

  • Headings
    • h1, h2, h3, h4, h5, h6
  • Body content
    • p, a, em, strong, abbr, sup, hr
  • Lists
    • ol, ul, dl, unstiled-list
  • Images
    • inline, block

Requirements

Change History (21)

comment:1 Changed 3 years ago by saroyanm

  • Blocking 4606 added
  • Cc juliandoucette added
  • Component changed from Unknown to Websites

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Owner set to juliandoucette
  • Summary changed from Start point for UDL implementation to UDL Content styles

comment:4 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by juliandoucette

  • Summary changed from UDL Content styles to UDL content styles

comment:6 Changed 3 years ago by juliandoucette

  • Blocking 4630 added

comment:7 Changed 3 years ago by juliandoucette

  • Blocking 4629 added

comment:8 Changed 3 years ago by juliandoucette

  • Blocking 4631 added

comment:9 Changed 3 years ago by juliandoucette

  • Priority changed from Unknown to P2
  • Ready set

comment:10 Changed 3 years ago by juliandoucette

  • Description modified (diff)

comment:11 Changed 3 years ago by juliandoucette

  • Description modified (diff)

comment:12 Changed 3 years ago by juliandoucette

  • Cc jeen p.pastourmatzis mvelchevski added

comment:13 Changed 3 years ago by juliandoucette

  • Cc greiner added

comment:14 Changed 3 years ago by juliandoucette

  • Description modified (diff)

comment:15 Changed 3 years ago by juliandoucette

  • Blocking 4633 added

comment:16 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Summary changed from UDL content styles to Default content styles

Updated name and requirements based on discussions in review.

comment:17 Changed 3 years ago by juliandoucette

  • Blocking 4630 removed

comment:18 Changed 3 years ago by juliandoucette

  • Blocking 4631 removed

comment:19 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4607 - Default content styles

comment:20 Changed 3 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:21 Changed 3 years ago by juliandoucette

  • Blocking 4633 removed
Note: See TracTickets for help on using tickets.