Opened 3 years ago

Closed 3 years ago

#4610 closed defect (fixed)

Safari development builds are failing

Reported by: kzar Assignee: trev
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: trev, sebastian, kvas Blocked By:
Blocking: #4551 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361784/

Description (last modified by trev)

How to reproduce

Update you local copy of the adblockpluschrome repository to master bookmark and try creating a Safari build:

./build.py -t safari build -k adblockplussafari.pem

Observed behaviour

The development build fails to be generated:

jinja2.exceptions.TemplateNotFound: xartoc.xml.tmpl

Expected behaviour

The build is generated successfully.

Background

This is a regression from #4028. All templates moved into templates/ directory there yet xartoc.xml.tmpl was forgotten for some reason - yet packager.getTemplate() is used to load this template and it looks in the templates/ directory now.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Cc kvas added
  • Description modified (diff)
  • Owner set to trev

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by kvas

  • Ready set

comment:5 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.