Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4616 closed change (fixed)

Push Edge related changes to the edge bookmark of adblockpluschrome

Reported by: kzar Assignee: oleksandr
Priority: P3 Milestone:
Module: Platform Keywords:
Cc: oleksandr, sebastian, jsonesen Blocked By:
Blocking: #4617 Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29365879/

Description

Background

Now that #4540 and #4028 are taken care of we are ready to start adding Microsoft Edge support to adblockpluschrome under the edge bookmark.

What to change

In order:

  1. Create an edge bookmark repository, pointing at the same revision as the master bookmark.
  2. Rebase the required changes for Edge support on top of the revision the edge and master bookmarks point to.
  3. Move the edge bookmark on to include all of those Edge support commits. Make sure the master bookmark was not moved.
  4. Ensure that building the Edge extension actually works, I found I needed to add a metadata.edge file for example.
  5. Push the new bookmark and related commits to adblockpluschrome.

Change History (10)

comment:1 Changed 3 years ago by kzar

  • Blocking 4617 added

comment:2 Changed 3 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from new to closed

Changes have been pushed.

comment:3 Changed 3 years ago by kzar

  • Cc jsonesen added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening since the metadata.edge file wasn't added and the build doesn't work yet. If it helps here's a hacked together metadata file I used for testing. (Note you'll need to remove the comment since that breaks things and also fix the icon paths with the proper images.)

Edit: Also note I made up values such as versions, you should check all those and correct them.

Last edited 3 years ago by kzar (previous) (diff)

comment:4 Changed 3 years ago by kzar

  • Owner set to oleksandr
  • Review URL(s) modified (diff)

comment:5 Changed 3 years ago by kzar

  • Status changed from reopened to reviewing

comment:7 Changed 3 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by sebastian

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, but it seems there is one more thing that needs to be changed in metadata.edge. As per #4578 we need to set extension_id_release = 1.0.

comment:9 Changed 2 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reopened to closed

The `extension_id_release = 1.0' change was added in #5315. Closing this.

comment:10 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This looks done. Can create Edge builds from the adblockpluschrome directory. The extension_id_release is in the metadata.edge file.

adblockpluschrome / 1846:44197859df84

Note: See TracTickets for help on using tickets.