Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4618 closed defect (fixed)

Acceptable Ads are not displayed on Ask.com and About.com in AdblockWebView

Reported by: scheer Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361445/#ps29361947

Description (last modified by scheer)

Acceptable Ads should display on search results within http://www.ask.com and http://www.about.com when AA is enabled via Settings > Adblock Plus Settings. Currently, it does not.

Environment

AdblockWebView (95) Lightning Browser
Galaxy S7
Android 6.0.1
Easylist
AA Enabled

How to reproduce

  1. Enable AA
  2. Navigate to http://www.ask.com or http://www.about.com
  3. Search for 'iPhone 6'

Observed behaviour

No ad results are shown.

Expected behaviour

Ad results should also be shown as well as web results.

Attachments (1)

Ask AdblockWebView Log.txt (318.2 KB) - added by scheer 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by scheer

comment:1 Changed 3 years ago by scheer

  • Description modified (diff)
  • Summary changed from Acceptable Ads are not displayed on Ask.com in AdblockWebView to Acceptable Ads are not displayed on Ask.com and About.com in AdblockWebView

comment:2 Changed 3 years ago by asmirnov

i can see no elem hiding selectors were applied, so AA was not elem hidden.
but i can see google ads request was blocked because of no referrer in request header:

// no elem hiding selectors 1
11-08 09:47:38.985 29726-30017/acr.browser.barebones D/AdblockWebView: Subscribed to [Subscription]
...
11-08 09:47:38.985 29726-30017/acr.browser.barebones D/AdblockWebView: Requesting elemhide selectors from AdblockEngine for http://www.ask.com/ in Thread[Thread-1027,5,main]
...
11-08 09:47:39.025 29726-30017/acr.browser.barebones D/AdblockWebView: Finished requesting elemhide selectors, got 0 in Thread[Thread-1027,5,main]

// no elem hiding selectors 2
11-08 09:47:39.255 29726-30020/acr.browser.barebones D/AdblockWebView: Subscribed to [Subscription]
596	                                                                       url=https://easylist-downloads.adblockplus.org/exceptionrules.txt
597	                                                                       title=Allow non-intrusive advertising
598	                                                                       fixedTitle=true
599	                                                                       homepage=https://acceptableads.org/
600	                                                                       lastDownload=1478594096
601	                                                                       downloadStatus=synchronize_ok
602	                                                                       lastSuccess=1478594096
603	                                                                       lastCheck=1478594432
604	                                                                       expires=1478766896
605	                                                                       softExpiration=1478664814
606	                                                                       version=201611080831
607	                                                                       requiredVersion=2.0
608	                                                                       downloadCount=1
609	11-08 09:47:39.255 29726-30020/acr.browser.barebones D/AdblockWebView: Requesting elemhide selectors from AdblockEngine for http://de.ask.com/?o=312&l=dir&ad=dirN in Thread[Thread-1028,5,main]
610	11-08 09:47:39.255 29726-29726/acr.browser.barebones D/BrowserActivity: Notify Tab Changed: 0
611	11-08 09:47:39.265 29726-30020/acr.browser.barebones D/AdblockWebView: Finished requesting elemhide selectors, got 0 in Thread[Thread-1028,5,main]

// blocked google ads becuase of no referrer
11-08 09:48:00.165 29726-29757/acr.browser.barebones W/AdblockWebView: No referrer header for https://www.google.com/afs/ads?q=Iphone%206&oe=utf-8&ie=utf-8&lo=false&adpage=1&adrep=5&r=m&fexp=21404&client=aj-de&channel=de-web&hl=de&adtest=off&adsafe=medium&type=0&format=p5%7Cn5&ad=n5p5&nocache=6221478594880135&num=0&output=uds_ads_only&v=3&adlh=on&adext=as1%2Csr1&bsl=10&u_his=11&u_tz=60&dt=1478594880142&u_w=360&u_h=640&biw=360&bih=558&psw=360&psh=1194&frm=0&uio=uv3cs1vp1lo0va1cc0sr1sl1hc-lHst17sd15sv14sa13lt20ld18lv16da1-lhst17sd15sv14sa13lt20ld18lv16da1&jsv=11676&rurl=http%3A%2F%2Fde.ask.com%2Fweb%3Fq%3DIphone%2B6%26qsrc%3D0%26o%3D0%26l%3Ddir%26qo%3DspellCheck&referer=http%3A%2F%2Fde.ask.com%2Fweb%3Fq%3DIphone6%26qsrc%3D0%26o%3D0%26l%3Ddir%26qo%3DhomepageSearchBox#master-1
1625	11-08 09:48:00.175 29726-29757/acr.browser.barebones W/AdblockWebView: Blocked loading https://www.google.com/afs/ads?q=Iphone%206&oe=utf-8&ie=utf-8&lo=false&adpage=1&adrep=5&r=m&fexp=21404&client=aj-de&channel=de-web&hl=de&adtest=off&adsafe=medium&type=0&format=p5%7Cn5&ad=n5p5&nocache=6221478594880135&num=0&output=uds_ads_only&v=3&adlh=on&adext=as1%2Csr1&bsl=10&u_his=11&u_tz=60&dt=1478594880142&u_w=360&u_h=640&biw=360&bih=558&psw=360&psh=1194&frm=0&uio=uv3cs1vp1lo0va1cc0sr1sl1hc-lHst17sd15sv14sa13lt20ld18lv16da1-lhst17sd15sv14sa13lt20ld18lv16da1&jsv=11676&rurl=http%3A%2F%2Fde.ask.com%2Fweb%3Fq%3DIphone%2B6%26qsrc%3D0%26o%3D0%26l%3Ddir%26qo%3DspellCheck&referer=http%3A%2F%2Fde.ask.com%2Fweb%3Fq%3DIphone6%26qsrc%3D0%26o%3D0%26l%3Ddir%26qo%3DhomepageSearchBox#master-1

comment:3 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by asmirnov

The source code changes will be included in issue 4399 files

Note: See TracTickets for help on using tickets.