Opened 2 years ago

Last modified 17 months ago

#4620 new change

Remove unused manifest permissions

Reported by: diegocarloslima Assignee:
Priority: P4 Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Currently, we have disabled some features of Firefox that requires a few permissions in the app manifest. It might be interesting to remove these permissions from our manifest, so pre-Marshmallow users will see less permissions requirements when installing our app from the Google Play Store.

What to change

Remove unused permissions from manifest.

Attachments (1)

Screenshot_20170912-155530.png​ (151.3 KB) - added by jwangenheim 17 months ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 17 months ago by diegocarloslima

  • Priority changed from Unknown to P4

comment:2 Changed 17 months ago by jwangenheim

With the merge of FENNEC 53 we start using runtime permissions, so the user does not have to grant any permission when installing ABB anymore. Permission now need to be granted as soon as they are needed for the first time (see attached screenshot).

@diego: Do you remember which permissions are obsolete? I think we can remove the following:

  • com.android.browser.permission.READ_HISTORY_BOOKMARKS -> as we don't support to import bookmarks and/or history anymore

I am not 100% sure about

  • uses-permission android:name="android.permission.DOWNLOAD_WITHOUT_NOTIFICATION"

Changed 17 months ago by jwangenheim

Note: See TracTickets for help on using tickets.