Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#4624 closed defect (fixed)

Element hiding rules apply on whitelisted schemes (chrome://, file:/// etc.)

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29362064/

Description

Environment

Adblock Plus 2.8.1.4224-beta

How to reproduce

  1. Paste the following text into a test.html file on your disk:
    <html>
      <body>
        <div id="div">
          This should not be hidden.
        </div>
      </body>
    </html>
    
  2. Add the filter ###div.
  3. Open that HTML page in your browser (location should be something like file:///foo/bar/test.html).

Observed behaviour

The text on the page is hidden.

Expected behaviour

The text should be visible - element hiding rules aren't supposed to apply to file:///.

Change History (4)

comment:1 Changed 2 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

Firefox 38 / 49 / Windows 7
Firefox Nightly 53.0a1 (2016-11-17) / Windows 7

Note: See TracTickets for help on using tickets.