Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#4625 closed change (fixed)

moz-extension:// should be a whitelisted scheme

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29362067/

Description

Background

Mozilla introduced moz-extension:// URL scheme for WebExtensions, it is being used for extension pages. So far we didn't whitelist that scheme in Adblock Plus and might still hide content on these pages.

What to change

Add moz-extension:// to the whitelisted schemes, these are special pages that Adblock Plus should not affect.

Change History (4)

comment:1 Changed 4 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 4625 - moz-extension:// should be a whitelisted scheme

comment:3 Changed 4 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Works as expected.

Firefox 49 / Windows 7
Firefox Nightly 53.0a1 (2016-11-17) / Windows 7

Note: See TracTickets for help on using tickets.