Opened 3 years ago

Closed 3 years ago

#4626 closed change (duplicate)

Update development build creation for Edge

Reported by: trev Assignee:
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: oleksandr, kzar, sebastian, kvas, jsonesen Blocked By: #4549
Blocking: #4617 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We want to start creating development builds for Edge. At the moment, the development build generation doesn't know what to do with this platform however. Following error is being thrown but that's only one of the issues:

  File "sitescripts/extensions/utils.py", line 175, in __init__
    self.packageSuffix = PACKAGE_SUFFIXES[self.type]
KeyError: 'edge'

What to change

  • Add Edge to sitescripts.extensions.utils.PACKAGE_SUFFIXES
  • Implement readEdgeMetadata() in sitescripts.extensions.bin.createNightlies and make sure it's being used.
  • Make sure a correct update manifest is being written?
  • If no updates are possible from our infrastructure, upload the build to Windows Store?

Change History (9)

comment:1 Changed 3 years ago by kzar

  • Cc oleksandr kzar sebastian kvas jsonesen added

comment:2 Changed 3 years ago by jsonesen

Hey I am happy to start working on this

comment:3 Changed 3 years ago by jsonesen

  • Blocked By 4549 added

comment:4 Changed 3 years ago by kvas

  • Priority changed from Unknown to P2
  • Ready set

comment:5 in reply to: ↑ description Changed 3 years ago by sebastian

  • Ready unset

Does this even make sense as a separate issue, or shouldn't it rather be merged into #4549? As long as development build creation fails there is no way to use/test the Windows Store integration anyway.

Replying to trev:

  • If no updates are possible from our infrastructure, upload the build to Windows Store?

Yes, serving the development builds from the Windows Store is mandatory, not only to get updates, but even to install and use it easily and without restrictions. That is what the issue mentioned above is about.

comment:6 Changed 3 years ago by jsonesen

so this is being moved as a task to 4549?

comment:7 follow-up: Changed 3 years ago by oleksandr

I would say yes. What I have for #4549 deals with bullet points listed here.

comment:8 in reply to: ↑ 7 Changed 3 years ago by kvas

Replying to oleksandr:

I would say yes. What I have for #4549 deals with bullet points listed here.

Do you think we can close this issue then?

comment:9 Changed 3 years ago by sebastian

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.