Opened 3 years ago

Last modified 3 years ago

#4639 reopened change

Remove easylist and easylistgermany repositories from our infrastructure

Reported by: trev Assignee: ferris
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: matze, nicole@…, arthur@… Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370769 (closed)
https://codereview.adblockplus.org/29370772 (closed)
https://codereview.adblockplus.org/29371597 (closed)
https://codereview.adblockplus.org/29371600 (abandoned)

Description

Background

easylist and easylistgermany repositories moved to GitHub but we are still syncing them to our Mercurial server. This is completely unnecessary as the generation process downloads the data directly from GitHub (see https://hg.adblockplus.org/easylistcombinations/file/tip/easylist.txt for example).

What to change

Remove the manually added cronjob importing easylist and easylistgermany from GitHub on hg1 - as well as its data. Remove the repositories themselves from hg1, these are unused and shouldn't be on our infrastructure in the first place. Remove these repositories from hiera/roles/filtermasterserver.yaml and the already checked out copies from the filter master servers.

Change History (15)

comment:1 Changed 3 years ago by ferris

  • Owner set to ferris

comment:2 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Removed cronjobs:

MAILTO=monitoring+easylist@adblockplus.org
*/5 * * * * cd ~/import/github/easylistgermany && git pull -q && hg -q -R ~/web/easylistgermany pull -u
*/5 * * * * cd ~/import/github/easylist && git pull -q && hg -q -R ~/web/easylist pull -u

Moved ~hg/import/ to ~hg/.import.old-and-disabled-4639/ for now (easylist and easylistgermany were the only ones in there, also in ~/import/legacy/).

Moved ~hg/web/easylist{,germany} into the above folder as well.

If nobody complains over the next few days, I'll remove them permanently.

I cannot currently access filtermaster1 - requested access to clean up there.

comment:3 Changed 3 years ago by ferris

Moved the repositories back into place for now as I need access to the filter masters in order to stop the cronjob there from failing (we just got a couple of annoying alert mails from the filtermasters).

comment:4 Changed 3 years ago by ferris

Remind myself to remove them from hgaccess as well.

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4639 - Remove easylist and easylistgermany

comment:6 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)

comment:7 Changed 3 years ago by ferris

  • Resolution set to fixed
  • Status changed from reviewing to closed

Got access to the filtermaster1 and filtermaster2 today. Provisioned them with the change.

Did this on both filtermasters:

mv subscription/easylist .disabled-subscription/
mv subscription/easylistgermany/ .disabled-subscription/

Then re-removed the repos on hg1 again.

No more cron error mails the last half hour.

comment:8 Changed 3 years ago by ferris

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 Changed 3 years ago by ferris

Reopening and reverting as per matze's request.

comment:10 Changed 3 years ago by matze

We actually have a set of legal requirements that result in our requirement to have these repositories and the synchronization. Hence easylistcombinations not referring to our own resources is actually an issue. I will clarify the situation accordingly.

comment:11 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)

comment:12 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4639 - Reverting the removal of list repos

comment:14 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)

comment:15 Changed 3 years ago by ferris

  • Cc nicole@… arthur@… added
  • Review URL(s) modified (diff)

All changes have been reverted again. This has to go through a more managed change process, or be clarified with the filterlist maintainers.

Note: See TracTickets for help on using tickets.