onBeforeRequest listener throwing exception for frames without a URL
|Cc:||trev, sebastian, BrentM, rhana@…, arthur||Blocked By:|
Chrome Version 54.0.2840.59 (64-bit)
How to reproduce
- Open the console for the extension's background page.
- Browse the web for a while.
Exceptions being thrown by the onBeforeRequest handler, for frames without a URL property.
Those exceptions should not be thrown.
The onBeforeRequest listener assumes that the originating frame will always have a URL. This is no longer true however since we now create frames with only the parent property in the onBeforeNavigate handler. Therefore I think this is a regression caused by Issue 4386 - Fixed determining document domain, particularly after being redirected.
We should now either ignore requests from frames without a URL or adapt the onBeforeRequest handler so that it does not assume the frame URL will be available. (Might be worthwhile since the parent frame might already have a URL.)
Change History (8)
comment:2 Changed 4 months ago by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed 3 weeks ago by kzar
- Resolution set to fixed
- Status changed from reviewing to closed