Opened 13 months ago

Closed 7 months ago

Last modified 7 months ago

#4648 closed change (fixed)

[ABP for Samsung Internet] - Update source string

Reported by: Shikitita Assignee: diegocarloslima
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: lisabielik, diegocarloslima, vickyyu, mario Blocked By:
Blocking: #4505 Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29366704/

Description

Background

A string currently used for ABP for Samsung Internet needs changing in order to keep consistency across platforms

What to change

"Allow some nonintrusive ads"

should be changed to

"Allow some nonintrusive advertising"

Change History (9)

comment:1 Changed 13 months ago by diegocarloslima

  • Owner set to diegocarloslima
  • Ready set

comment:2 Changed 12 months ago by diegocarloslima

  • Blocking 4505 added

comment:3 Changed 12 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 4648 - [ABP for Samsung Internet - Update source string]

comment:5 Changed 12 months ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 7 months ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer
  • On the first run screen, the wording remains as 'You can change this setting at any time by tapping the Allow some nonintrusive ads option' instead of nonintrusive advertising.

adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0
Samsung Internet 5.0+

adblockplussbrowser-release-signed-1
Galaxy S5
Android 5.0.1
Samsung Internet 4.0

comment:7 Changed 7 months ago by diegocarloslima

@scheer, the aforementioned issue will be fixed on #5215

comment:8 Changed 7 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reopened to closed

As #5215 was fixed for version 1.1.0, this ticket can be closed.

comment:9 Changed 7 months ago by scheer

  • Verified working set
  • On the first run screen, the correct wording "Allow some nonintrusive advertising" is used.

adblockplussbrowser-release-signed-2
Galaxy S4
Android 5.0.1

adblockplussbrowser-release-signed-2
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.